rangadi opened a new pull request, #38286:
URL: https://github.com/apache/spark/pull/38286
### What changes were proposed in this pull request?
Adds support for compiled Java classes to Protobuf functions. This is tested
with Protobuf v3 classes. V2 vs V3 issues will be handled in a separate PR. The
main changes in this PR:
- Changes to top level API:
- Adds new version that takes just the class name.
- Changes the order of arguments for existing API with descriptor files
(`messageName` and `descFilePath` are swapped).
- Protobuf utils methods to create descriptor from Java class name.
- Many unit tests are update to check both versions : (1) with descriptor
file and (2) with Java class name.
- Maven build updates to generate Java classes to use in tests.
- Miscellaneous changes:
- Adds `proto` to package name in `proto` files used in tests.
- A few TODO comments about improvements
### Why are the changes needed?
Java compiled classes is a common method for users to provide Protobuf
definitions.
### Does this PR introduce _any_ user-facing change?
No.
This updates interface, but for a new feature in active development.
### How was this patch tested?
- Unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
