rangadi commented on code in PR #38286:
URL: https://github.com/apache/spark/pull/38286#discussion_r997748022
##########
connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/utils/SchemaConverters.scala:
##########
@@ -66,6 +66,10 @@ object SchemaConverters {
Some(DayTimeIntervalType.defaultConcreteType)
case MESSAGE if fd.getMessageType.getName == "Timestamp" =>
Some(TimestampType)
+ // FIXME: Is the above accurate? Users can have protos named
"Timestamp" but are not
Review Comment:
Yeah, we could verify it matches a message like `{ int64 seconds = 1; int32
nanos = 2 }`. This will match with ones defined in protobuf package too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
