itholic commented on code in PR #38291:
URL: https://github.com/apache/spark/pull/38291#discussion_r998076086


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -1830,6 +1830,13 @@ object SQLConf {
       .stringConf
       .createWithDefault("lz4")
 
+  val CHECKPOINT_RENAMEDFILE_CHECK_ENABLED =
+    buildConf("spark.sql.streaming.checkpoint.renamedFileCheck")

Review Comment:
   I think maybe we usually use "enabled" keyword for string when "ENABLED" is 
following in the postfix for option?
   
   So, for example:
   ```diff
   -  "spark.sql.streaming.checkpoint.renamedFileCheck"
   +  "spark.sql.streaming.checkpoint.renamedFileCheck.enabled"
   ```
   
   WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to