EnricoMi commented on code in PR #38312:
URL: https://github.com/apache/spark/pull/38312#discussion_r1000224749
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetSchemaConverter.scala:
##########
@@ -271,6 +271,8 @@ class ParquetToSparkSchemaConverter(
} else {
TimestampNTZType
}
+ case timestamp: TimestampLogicalTypeAnnotation if timestamp.getUnit
== TimeUnit.NANOS =>
Review Comment:
Ideally, this case would be merged with above case, but that would require
`TimestampType` and `TimestampNTZType` to support nanos, which is a bigger
change.
This `case` deserves a comment that nanos are not supported as
`TimestampType` but as `LongType`, without any timezone awareness.
Supporting nanos as `TimestampType` in the future looks like a breaking
change then (Spark 4.x?). Or another `TimestampNSType` like `TimstampNTZType`
could be introduced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
