ulysses-you commented on code in PR #38302:
URL: https://github.com/apache/spark/pull/38302#discussion_r1001277175
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/SQLExecution.scala:
##########
@@ -115,7 +115,8 @@ object SQLExecution {
throw e
} finally {
val endTime = System.nanoTime()
- val event = SparkListenerSQLExecutionEnd(executionId,
System.currentTimeMillis())
+ val event = SparkListenerSQLExecutionEnd(
+ executionId, System.currentTimeMillis(), ex.map(_.getMessage))
Review Comment:
here we catch all `Throwable`, how about this ?
```scala
ex.map {
case e: SparkThrowable =>
SparkThrowableHelper.getMessage(e, ErrorMessageFormat.STANDARD)
case e =>
// unexpected behavior
s"${e.getClass.getCanonicalName}: ${e.getMessage}"
})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
