amaliujia commented on code in PR #38301:
URL: https://github.com/apache/spark/pull/38301#discussion_r1002886560
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/DataTypeProtoConverter.scala:
##########
@@ -50,11 +50,27 @@ object DataTypeProtoConverter {
proto.DataType.newBuilder().setI32(proto.DataType.I32.getDefaultInstance).build()
case StringType =>
proto.DataType.newBuilder().setString(proto.DataType.String.getDefaultInstance).build()
+ case LongType =>
+
proto.DataType.newBuilder().setI64(proto.DataType.I64.getDefaultInstance).build()
+ case struct: StructType =>
+ toConnectProtoStructType(struct)
case _ =>
throw InvalidPlanInput(s"Does not support convert ${t.typeName} to
connect proto types.")
}
}
+ def toConnectProtoStructType(schema: StructType): proto.DataType = {
+ val struct = proto.DataType.Struct.newBuilder()
+ for (structField <- schema.fields) {
+ struct.addFields(
+ proto.DataType.StructField
+ .newBuilder()
+ .setName(structField.name)
+ .setType(toConnectProtoType(structField.dataType)))
Review Comment:
Entire nullability is ignored so far in current Connect implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
