amaliujia commented on code in PR #38345:
URL: https://github.com/apache/spark/pull/38345#discussion_r1004046961
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -238,13 +238,17 @@ package object dsl {
def join(
otherPlan: proto.Relation,
joinType: JoinType = JoinType.JOIN_TYPE_INNER,
+ usingColumns: Seq[String] = Seq(),
Review Comment:
Looks like only one overloaded version can have default arguments:
[ERROR]
/Users/rui.wang/Documents/open-source-spark/spark/connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:176:
in class DslLogicalPlan, multiple overloaded alternatives of method join
define default arguments.
I ended up with adding a few more overloaded version of `def join`.
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -109,6 +109,10 @@ message Join {
Relation right = 2;
Expression join_condition = 3;
JoinType join_type = 4;
+ // Optional. using_columns provides a list of columns that should present on
both sides of
+ // the join inputs that this Join will join on. For example A JOIN B USING
col_name is
+ // equivalent to A JOIN B on A.col_name = B.col_name.
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
