mridulm commented on code in PR #37638:
URL: https://github.com/apache/spark/pull/37638#discussion_r1003656427
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -593,6 +607,9 @@ public void onData(String streamId, ByteBuffer buf) {
@Override
public void onComplete(String streamId) {
+ if (isTooLate) {
+ pushMergeMetrics.tooLateResponses.mark();
+ }
Review Comment:
Yes, but is there a reason to defer updating the metric to later ? It is
clear at time of callback construction itself that it is late.
I am not sure if we want to make the distinction for late w.r.t onComplete
vs onFailure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
