HyukjinKwon commented on code in PR #38392:
URL: https://github.com/apache/spark/pull/38392#discussion_r1005067738
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/dsl/package.scala:
##########
@@ -26,11 +26,14 @@ import
org.apache.spark.sql.connect.planner.DataTypeProtoConverter
/**
* A collection of implicit conversions that create a DSL for constructing
connect protos.
+ *
+ * All classes in connect/dsl are considered an internal API to Spark Connect
and are subject to
+ * change between minor releases.
*/
package object dsl {
- object expressions { // scalastyle:ignore
+ private[connect] object expressions { // scalastyle:ignore
Review Comment:
If we document this as an internal package, I think it's fine to remove
`private[connect]`, see also SPARK-16964 and SPARK-16813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
