cloud-fan commented on code in PR #38274:
URL: https://github.com/apache/spark/pull/38274#discussion_r1005163283
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/AlterNamespaceSetLocationSuiteBase.scala:
##########
@@ -45,10 +46,13 @@ trait AlterNamespaceSetLocationSuiteBase extends QueryTest
with DDLCommandTestUt
val ns = s"$catalog.$namespace"
withNamespace(ns) {
sql(s"CREATE NAMESPACE $ns")
- val message = intercept[IllegalArgumentException] {
- sql(s"ALTER NAMESPACE $ns SET LOCATION ''")
- }.getMessage
- assert(message.contains("Can not create a Path from an empty string"))
+ val sqlText = s"ALTER NAMESPACE $ns SET LOCATION ''"
Review Comment:
I think we can move this test to the base suite now, as the behavior is
consistent between v1 and v2 tables.
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/CreateNamespaceSuiteBase.scala:
##########
@@ -67,15 +68,15 @@ trait CreateNamespaceSuiteBase extends QueryTest with
DDLCommandTestUtils {
// The generated temp path is not qualified.
val path = tmpDir.getCanonicalPath
assert(!path.startsWith("file:/"))
-
- val e = intercept[IllegalArgumentException] {
- sql(s"CREATE NAMESPACE $ns LOCATION ''")
- }
- assert(e.getMessage.contains("Can not create a Path from an empty
string"))
-
+ val sqlText = s"CREATE NAMESPACE $ns LOCATION ''"
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
