srielau commented on code in PR #38000:
URL: https://github.com/apache/spark/pull/38000#discussion_r1005880203
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -1064,32 +1069,49 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase {
invalidValue: String,
allowedValues: Option[String] = None): Throwable = {
val endingMsg = allowedValues.map(" " + _).getOrElse("")
- new AnalysisException(s"Invalid value for the '$argName' parameter of
function '$funcName': " +
- s"$invalidValue.$endingMsg")
+ new AnalysisException(
+ errorClass = "_LEGACY_ERROR_TEMP_1101",
+ messageParameters = Map(
+ "argName" -> argName,
+ "funcName" -> funcName,
+ "invalidValue" -> invalidValue,
+ "endingMsg" -> endingMsg))
}
def literalTypeUnsupportedForSourceTypeError(field: String, source:
Expression): Throwable = {
- new AnalysisException(s"Literals of type '$field' are currently not
supported " +
- s"for the ${source.dataType.catalogString} type.")
+ new AnalysisException(
+ errorClass = "_LEGACY_ERROR_TEMP_1102",
+ messageParameters = Map(
+ "field" -> field,
+ "srcDataType" -> source.dataType.catalogString))
}
def arrayComponentTypeUnsupportedError(clz: Class[_]): Throwable = {
- new AnalysisException(s"Unsupported component type $clz in arrays")
+ new AnalysisException(
+ errorClass = "_LEGACY_ERROR_TEMP_1103",
+ messageParameters = Map("clz" -> clz.toString))
}
def secondArgumentNotDoubleLiteralError(): Throwable = {
- new AnalysisException("The second argument should be a double literal.")
+ new AnalysisException(
+ errorClass = "_LEGACY_ERROR_TEMP_1104",
+ messageParameters = Map.empty)
Review Comment:
@MaxGekk I'm proposing to leave the Map.empty in (status quo) as an explicit
reminder in the code that this message takes no arguments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
