HeartSaVioR commented on code in PR #38405:
URL: https://github.com/apache/spark/pull/38405#discussion_r1006548661


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SessionWindow.scala:
##########
@@ -68,11 +68,29 @@ case class SessionWindow(timeColumn: Expression, 
gapDuration: Expression) extend
   with Unevaluable
   with NonSQLExpression {
 
+  private def inputTypeOnTimeColumn: AbstractDataType = {

Review Comment:
   (Oh I missed that the change from rule side has already merged in as a part 
of introduction of `window_time`.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to