amaliujia commented on code in PR #38406:
URL: https://github.com/apache/spark/pull/38406#discussion_r1007318294
##########
connector/connect/src/test/scala/org/apache/spark/sql/connect/planner/SparkConnectProtoSuite.scala:
##########
@@ -215,4 +180,16 @@ class SparkConnectProtoSuite extends PlanTest with
SparkConnectPlanTest {
}
proto.Relation.newBuilder().setLocalRelation(localRelationBuilder.build()).build()
}
+
+ private def analyzePlan(plan: LogicalPlan): LogicalPlan = {
+ val connectAnalyzed = analysis.SimpleAnalyzer.execute(plan)
+ analysis.SimpleAnalyzer.checkAnalysis(connectAnalyzed)
+ EliminateSubqueryAliases(connectAnalyzed)
Review Comment:
hmmm this is what I borrowed from
https://github.com/apache/spark/blob/c50d865fa9eb5207bc8c9992e37843412ec0cbc3/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala#L513
We are using this Catalyst DSL analyze call already before this refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
