rahulsmahadev commented on code in PR #38404: URL: https://github.com/apache/spark/pull/38404#discussion_r1007450737
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala: ########## @@ -1276,6 +1276,24 @@ class Analyzer(override val catalogManager: CatalogManager) AppendData.byPosition(r, query) } else if (conf.partitionOverwriteMode == PartitionOverwriteMode.DYNAMIC) { OverwritePartitionsDynamic.byPosition(r, query) + } else if (i.replacePredicates.nonEmpty) { + def findAttrInRelation(name: String): Attribute = { Review Comment: we should check with OSS reviewers(once this PR is ready) if there is some existing method for this, so that we don't need to duplicate code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org