dongjoon-hyun commented on code in PR #38397:
URL: https://github.com/apache/spark/pull/38397#discussion_r1007642185
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala:
##########
@@ -173,6 +181,22 @@ class ParquetFileFormat
val datetimeRebaseModeInRead = parquetOptions.datetimeRebaseModeInRead
val int96RebaseModeInRead = parquetOptions.int96RebaseModeInRead
+ // Should always be set by FileSourceScanExec creating this.
+ // Check conf before checking option, to allow working around an issue by
changing conf.
+ val returningBatch =
sparkSession.sessionState.conf.parquetVectorizedReaderEnabled &&
+ options.get(FileFormat.OPTION_RETURNING_BATCH)
+ .getOrElse {
+ throw new IllegalArgumentException(
+ "OPTION_RETURNING_BATCH should always be set for
ParquetFileFormat." +
Review Comment:
Ditto. nit. Add one more space at the end of the message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
