Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/6205#discussion_r30484698
--- Diff: core/src/main/scala/org/apache/spark/util/RpcUtils.scala ---
@@ -47,14 +46,24 @@ object RpcUtils {
}
/** Returns the default Spark timeout to use for RPC ask operations. */
- def askTimeout(conf: SparkConf): FiniteDuration = {
- conf.getTimeAsSeconds("spark.rpc.askTimeout",
- conf.get("spark.network.timeout", "120s")) seconds
+ def askTimeout(conf: SparkConf): RpcTimeout = {
+ try {
+ RpcTimeout(conf, "spark.rpc.askTimeout")
+ }
+ catch {
+ case _: Throwable =>
+ RpcTimeout(conf, "spark.network.timeout", "120s")
--- End diff --
I like the second idea, I'll add that in another commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
