cloud-fan commented on code in PR #38166:
URL: https://github.com/apache/spark/pull/38166#discussion_r1009009746
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -127,15 +127,19 @@ message Join {
}
}
-// Relation of type [[Union]], at least one input must be set.
-message Union {
- repeated Relation inputs = 1;
- UnionType union_type = 2;
-
- enum UnionType {
- UNION_TYPE_UNSPECIFIED = 0;
- UNION_TYPE_DISTINCT = 1;
- UNION_TYPE_ALL = 2;
+// Relation of type [[SetOperation]]
+message SetOperation {
+ Relation left_input = 1;
+ Relation right_input = 2;
+ SetOpType set_op_type = 3;
+ bool is_all = 4;
+ bool union_by_name = 5;
Review Comment:
just `by_name`, as it applies to all set operations in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
