thejdeep commented on code in PR #36165:
URL: https://github.com/apache/spark/pull/36165#discussion_r1010566209
##########
core/src/test/scala/org/apache/spark/util/JsonProtocolSuite.scala:
##########
@@ -2623,48 +2677,118 @@ private[spark] object JsonProtocolSuite extends
Assertions {
| },
| {
| "ID": 19,
+ | "Name": "${shuffleRead.FALLBACK_COUNT}",
+ | "Update": 0,
+ | "Internal": true,
+ | "Count Failed Values": true
+ | },
+ | {
+ | "ID" : 20,
+ | "Name" : "${shuffleRead.REMOTE_MERGED_BLOCKS_FETCHED}",
+ | "Update" : 0,
+ | "Internal" : true,
+ | "Count Failed Values" : true
+ | },
+ | {
+ | "ID" : 21,
+ | "Name" : "${shuffleRead.LOCAL_MERGED_BLOCKS_FETCHED}",
+ | "Update" : 0,
+ | "Internal" : true,
+ | "Count Failed Values" : true
+ | },
+ | {
+ | "ID" : 22,
+ | "Name" : "${shuffleRead.REMOTE_MERGED_CHUNKS_FETCHED}",
+ | "Update" : 0,
+ | "Internal" : true,
+ | "Count Failed Values" : true
+ | },
+ | {
+ | "ID" : 23,
+ | "Name" : "${shuffleRead.LOCAL_MERGED_CHUNKS_FETCHED}",
+ | "Update" : 0,
+ | "Internal" : true,
+ | "Count Failed Values" : true
+ | },
+ | {
+ | "ID" : 24,
+ | "Name" : "${shuffleRead.REMOTE_MERGED_BLOCKS_READ}",
+ | "Update" : 0,
+ | "Internal" : true,
+ | "Count Failed Values" : true
+ | },
+ | {
+ | "ID" : 25,
+ | "Name" : "${shuffleRead.LOCAL_MERGED_BLOCKS_READ}",
+ | "Update" : 0,
+ | "Internal" : true,
+ | "Count Failed Values" : true
+ | },
+ | {
+ | "ID" : 26,
+ | "Name" : "${shuffleRead.REMOTE_REQS_DURATION}",
+ | "Update" : 0,
+ | "Internal" : true,
+ | "Count Failed Values" : true
+ | },
+ | {
+ | "ID" : 27,
+ | "Name" : "${shuffleRead.REMOTE_MERGED_REQS_DURATION}",
+ | "Update" : 0,
+ | "Internal" : true,
+ | "Count Failed Values" : true
+ | },
+ | {
+ | "ID": 28,
+ | "Name": "${shuffleWrite.BYTES_WRITTEN}",
+ | "Update": 0,
+ | "Internal": true,
+ | "Count Failed Values": true
+ | },
+ | {
+ | "ID": 29,
| "Name": "${shuffleWrite.RECORDS_WRITTEN}",
| "Update": 0,
| "Internal": true,
| "Count Failed Values": true
| },
| {
- | "ID": 20,
+ | "ID": 30,
| "Name": "${shuffleWrite.WRITE_TIME}",
| "Update": 0,
| "Internal": true,
| "Count Failed Values": true
| },
| {
- | "ID": 21,
+ | "ID": 31,
| "Name": "${input.BYTES_READ}",
| "Update": 2100,
| "Internal": true,
| "Count Failed Values": true
| },
| {
- | "ID": 22,
+ | "ID": 32,
| "Name": "${input.RECORDS_READ}",
| "Update": 21,
| "Internal": true,
| "Count Failed Values": true
| },
| {
- | "ID": 23,
+ | "ID": 33,
| "Name": "${output.BYTES_WRITTEN}",
| "Update": 1200,
| "Internal": true,
| "Count Failed Values": true
| },
| {
- | "ID": 24,
+ | "ID": 34,
| "Name": "${output.RECORDS_WRITTEN}",
Review Comment:
The values just changed since metrics were added that took the place of
indices preceding this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
