cloud-fan commented on code in PR #38475:
URL: https://github.com/apache/spark/pull/38475#discussion_r1011251487


##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -250,3 +251,15 @@ message SubqueryAlias {
   // Optional. Qualifier of the alias.
   repeated string qualifier = 3;
 }
+
+// Rename columns on the input relation.
+message RenameColumns {

Review Comment:
   We definitely need this proto message, and we can probably add a 
corresponding logical if https://github.com/apache/spark/pull/38395 is the 
right direction.
   
   cc @HyukjinKwon 



##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -250,3 +251,15 @@ message SubqueryAlias {
   // Optional. Qualifier of the alias.
   repeated string qualifier = 3;
 }
+
+// Rename columns on the input relation.
+message RenameColumns {

Review Comment:
   We definitely need this proto message, and we can probably add a 
corresponding logical plan if https://github.com/apache/spark/pull/38395 is the 
right direction.
   
   cc @HyukjinKwon 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to