zzzzming95 commented on code in PR #38356:
URL: https://github.com/apache/spark/pull/38356#discussion_r1012507610
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/V1Writes.scala:
##########
@@ -178,7 +180,15 @@ object V1WritesUtils {
} else {
// We should first sort by dynamic partition columns, then bucket id,
and finally sorting
Review Comment:
> Should the outer Sort("p") better not be added in the first place, as the
inner Sort("p", "sort_col") provides this order already? See
https://github.com/apache/spark/pull/38358.
@EnricoMi
There is a constraint on the order of the sorting fields. If outer Sort("p")
added in the first place., will this constraint be broken, will it affect the
efficiency or other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
