HyukjinKwon commented on code in PR #38485: URL: https://github.com/apache/spark/pull/38485#discussion_r1012582471
########## python/pyspark/sql/tests/connect/test_connect_basic.py: ########## @@ -18,6 +18,9 @@ import unittest import shutil import tempfile + +import grpc # type: ignore Review Comment: Maybe we can do this separately but we should have a logic like `have_pandas` for the main codes too. The main problem is that PySpark itself doesn't have anything as a required dependency, and difficult to add a hard required dependency. e.g., you download Spark binary from https://spark.apache.org/downloads.html in the cluster, and the basic functionality should work. If `grpc` is not installed, it should show the proper exception message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
