amaliujia commented on code in PR #38485: URL: https://github.com/apache/spark/pull/38485#discussion_r1013190731
########## python/pyspark/sql/connect/client.py: ########## @@ -42,6 +43,125 @@ logging.basicConfig(level=logging.INFO) +class ChannelBuilder: + """ + This is a helper class that is used to create a GRPC channel based on the given + connection string per the documentation of Spark Connect. + """ + + PARAM_USE_SSL = "use_ssl" + PARAM_TOKEN = "token" + PARAM_USER_ID = "user_id" Review Comment: Is this a well known thing for connection string? If not can we BTW update the doc to mention this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
