dongjoon-hyun commented on code in PR #38331:
URL: https://github.com/apache/spark/pull/38331#discussion_r1013200861
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/KubernetesConfSuite.scala:
##########
@@ -250,4 +250,8 @@ class KubernetesConfSuite extends SparkFunSuite {
assert(KubernetesConf.getAppNameLabel("a" * 62 + "-aaa") === "a" * 62)
assert(KubernetesConf.getAppNameLabel("-" + "a" * 63) === "a" * 62)
}
+
+ test("SPARK-40869: KubernetesConf.getResourceNamePrefix creates invalid name
prefixes") {
Review Comment:
The test case title is too broad. Shall we match it with the title?
```scala
- test("SPARK-40869: KubernetesConf.getResourceNamePrefix creates invalid
name prefixes") {
+ test("SPARK-40869: getResourceNamePrefix should remove leading hypens") {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
