mridulm commented on code in PR #38377:
URL: https://github.com/apache/spark/pull/38377#discussion_r1014469439
##########
core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala:
##########
@@ -142,7 +142,7 @@ private[spark] class DriverLogger(conf: SparkConf) extends
Logging {
threadpool =
ThreadUtils.newDaemonSingleThreadScheduledExecutor("dfsSyncThread")
threadpool.scheduleWithFixedDelay(this, UPLOAD_INTERVAL_IN_SECS,
UPLOAD_INTERVAL_IN_SECS,
TimeUnit.SECONDS)
- logInfo(s"Started driver log file sync to: ${dfsLogFile}")
+ logInfo(s"Started driver log file sync to: ${dfsLogFile.toString}")
Review Comment:
nit: remove `.toString`
##########
core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala:
##########
@@ -126,13 +126,13 @@ private[spark] class DriverLogger(conf: SparkConf)
extends Logging {
throw new RuntimeException(s"${rootDir} does not exist." +
s" Please create this dir in order to persist driver logs")
}
- val dfsLogFile: String = FileUtils.getFile(rootDir, appId
- + DriverLogger.DRIVER_LOG_FILE_SUFFIX).getAbsolutePath()
+ val dfsLogFile: Path = fileSystem.makeQualified(new Path(rootDir, appId
+ + DriverLogger.DRIVER_LOG_FILE_SUFFIX))
Review Comment:
Looking at it more, given all resolution is related to `fileSystem`, we dont
need to either resolve or qualify it technically - the only reason to do so is
for the log message below: so I am fine with this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
