jzhuge commented on code in PR #37556: URL: https://github.com/apache/spark/pull/37556#discussion_r1014506227
########## sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/View.java: ########## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.connector.catalog; + +import java.util.Map; + +import org.apache.spark.annotation.DeveloperApi; +import org.apache.spark.sql.types.StructType; + +/** + * An interface representing a persisted view. + */ +@DeveloperApi +public interface View { + /** + * A name to identify this view. + */ + String name(); + + /** + * The view query SQL text. + */ + String sql(); + + /** + * The current catalog when the view is created. + */ + String currentCatalog(); + + /** + * The current namespace when the view is created. + */ + String[] currentNamespace(); + + /** + * The schema for the SQL text when the view is created. + */ + StructType schema(); + + /** + * The view column aliases. + */ + String[] columnAliases(); + Review Comment: No, `schema()` contains the final schema, the same as V1, to reduce confusion. I will update javadoc to clarify. Thank you and @wmoustafa for calling it out! For V1, schema stores column aliases. But for V2, we decided to use these metadata fields to capture the entire CREATE VIEW statement instead of relying on `schema` which feels more like "derived": - sql - columnAliases - columnComments Let me know if this makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
