HeartSaVioR commented on code in PR #38503:
URL: https://github.com/apache/spark/pull/38503#discussion_r1016177560
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala:
##########
@@ -169,16 +179,24 @@ object UnsupportedOperationChecker extends Logging {
"DataFrames/Datasets")(plan)
}
- // Disallow multiple streaming aggregations
- val aggregates = collectStreamingAggregates(plan)
+ val statefulOps = plan.collect {
+ case p: LogicalPlan if isStatefulOperation(p) => p
+ }
- if (aggregates.size > 1 && outputMode != InternalOutputModes.Append) {
+ if (statefulOps.size > 1 &&
+ outputMode != InternalOutputModes.Append &&
Review Comment:
nit: indent this line and next line (2 spaces more)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]