itholic commented on code in PR #38551:
URL: https://github.com/apache/spark/pull/38551#discussion_r1016194289
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -2764,7 +2764,7 @@ private[sql] object QueryExecutionErrors extends
QueryErrorsBase {
def multipleRowSubqueryError(context: SQLQueryContext): Throwable = {
new SparkException(
- errorClass = "MULTI_VALUE_SUBQUERY_ERROR",
+ errorClass = "SCALAR_SUBQUERY_TOO_MANY_ROWS",
Review Comment:
Not sure, but I think it's okay for now since it's not revealed to
end-users, and maybe the specific naming is better for developer rather than
general term ??
But I can fix it together within this PR if there is any better suggestions!
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala:
##########
@@ -2764,7 +2764,7 @@ private[sql] object QueryExecutionErrors extends
QueryErrorsBase {
def multipleRowSubqueryError(context: SQLQueryContext): Throwable = {
new SparkException(
- errorClass = "MULTI_VALUE_SUBQUERY_ERROR",
+ errorClass = "SCALAR_SUBQUERY_TOO_MANY_ROWS",
Review Comment:
Not sure, but I think it's okay for now since it's not revealed to
end-users, and maybe the specific naming is better for developers rather than
general term ??
But I can fix it together within this PR if there is any better suggestions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
