amaliujia commented on code in PR #38587:
URL: https://github.com/apache/spark/pull/38587#discussion_r1018580123
##########
connector/connect/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -280,9 +280,22 @@ message RenameColumns {
// Required. The input relation.
Relation input = 1;
- // Required.
+ // Optional.
//
// The number of columns of the input relation must be equal to the length
// of this field. If this is not true, an exception will be returned.
+ //
+ // This field does not co-exist with the field `rename_columns_map`.
Review Comment:
To me, it seems to have two separate approaches:
1. use enum to decide which field to use (and document those well).
2. split into independent messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
