amaliujia commented on code in PR #38468:
URL: https://github.com/apache/spark/pull/38468#discussion_r1018697387
##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectStreamHandler.scala:
##########
@@ -114,10 +123,97 @@ class SparkConnectStreamHandler(responseObserver:
StreamObserver[Response]) exte
responseObserver.onNext(response.build())
}
- responseObserver.onNext(sendMetricsToResponse(clientId, rows))
+ responseObserver.onNext(sendMetricsToResponse(clientId, dataframe))
responseObserver.onCompleted()
}
+ def processRowsAsArrowBatches(clientId: String, dataframe: DataFrame): Unit
= {
+ val spark = dataframe.sparkSession
+ val schema = dataframe.schema
+ // TODO: control the batch size instead of max records
Review Comment:
interesting. I only know that gRPC has a hard limits of 2GB/s transfer rate.
Never know it might not favor over large messages.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
