fred-db commented on code in PR #38497: URL: https://github.com/apache/spark/pull/38497#discussion_r1019250270
########## sql/core/src/test/scala/org/apache/spark/sql/SubqueryHintPropagationSuite.scala: ########## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql + +import org.apache.spark.sql.catalyst.expressions.{AttributeReference, Expression} +import org.apache.spark.sql.catalyst.plans.{InnerLike, LeftSemi} +import org.apache.spark.sql.catalyst.plans.logical.{BROADCAST, HintInfo, Join, JoinHint, LogicalPlan} +import org.apache.spark.sql.functions.col +import org.apache.spark.sql.test.SharedSparkSession + +class SubqueryHintPropagationSuite extends QueryTest with SharedSparkSession { + + setupTestData() + + private val expectedHint = + Some(HintInfo(strategy = Some(BROADCAST))) + private val hints = Seq("BROADCAST", "SHUFFLE_MERGE") Review Comment: It can also surface other bugs if one or more hints are in the plan on subqueries, e.g. during Analysis. For example `cleanQueryInScalarSubquery ` in `checkAnalysis` would fail if it would not have been written recursively. ########## sql/core/src/test/scala/org/apache/spark/sql/SubqueryHintPropagationSuite.scala: ########## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql + +import org.apache.spark.sql.catalyst.expressions.{AttributeReference, Expression} +import org.apache.spark.sql.catalyst.plans.{InnerLike, LeftSemi} +import org.apache.spark.sql.catalyst.plans.logical.{BROADCAST, HintInfo, Join, JoinHint, LogicalPlan} +import org.apache.spark.sql.functions.col +import org.apache.spark.sql.test.SharedSparkSession + +class SubqueryHintPropagationSuite extends QueryTest with SharedSparkSession { + + setupTestData() + + private val expectedHint = + Some(HintInfo(strategy = Some(BROADCAST))) + private val hints = Seq("BROADCAST", "SHUFFLE_MERGE") Review Comment: It can also surface other bugs if one or more hints are in the plan on subqueries during Analysis. For example `cleanQueryInScalarSubquery ` in `checkAnalysis` would fail if it would not have been written recursively. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
