amaliujia commented on PR #38606:
URL: https://github.com/apache/spark/pull/38606#issuecomment-1311202518

   @cloud-fan 
   
   We need to a bit more discussion on when to use `optional`. Right now the 
most obvious usage is to replace those `message` wrap.
   
   One example is, if a field is required, should we use `optional` notion? It 
acutally makes sense that required field are those that we need to know whether 
that is set or not, and `optional` notion offers `hasXXX` to help us tell that.
   
   You see the `optional` itself becomes tricky when we think our need for 
`required`, `optional with default value`, `optional without default value`, 
etc.
   
   I think we need more time to think this through.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to