rangadi commented on code in PR #38603:
URL: https://github.com/apache/spark/pull/38603#discussion_r1019850935
##########
python/pyspark/sql/protobuf/functions.py:
##########
@@ -48,8 +48,11 @@ def from_protobuf(
----------
data : :class:`~pyspark.sql.Column` or str
the binary column.
- messageName: str
- the protobuf message name to look for in descriptor file.
+ messageName: str, optional
+ the protobuf message name to look for in descriptor file. Or
+ The Protobuf class name. E.g.
``org.spark.examples.protobuf.ExampleEvent``,
Review Comment:
We need to add a comment about shading requirement. In scala, I am changing
this name to `shadedMessageClassName`. See scaladoc update in open PR here:
https://github.com/apache/spark/pull/38384/files#diff-93adb6d1143432aff776baed60d056133658635a2d8f9d29d925018fada64ff7R76-R83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
