MaxGekk commented on code in PR #38615:
URL: https://github.com/apache/spark/pull/38615#discussion_r1020704358
##########
core/src/main/resources/error/error-classes.json:
##########
@@ -630,6 +630,11 @@
"Input schema <jsonSchema> can only contain STRING as a key type for a
MAP."
]
},
+ "INVALID_LIKE_PATTERN" : {
+ "message" : [
+ "The pattern '<pattern>' is invalid, <message>."
Review Comment:
Actually, the message comes from Spark's code, see:
https://github.com/apache/spark/blob/70ec696bce7012b25ed6d8acec5e2f3b3e127f11/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala#L50
and there are just 2 messages:
1.
https://github.com/apache/spark/blob/70ec696bce7012b25ed6d8acec5e2f3b3e127f11/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala#L59
2.
https://github.com/apache/spark/blob/70ec696bce7012b25ed6d8acec5e2f3b3e127f11/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala#L61
@panbingkun Could you place the messages to the JSON files instead of
leaving them in the source code, please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
