mridulm commented on code in PR #38441: URL: https://github.com/apache/spark/pull/38441#discussion_r1020854651
########## core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala: ########## @@ -145,6 +145,13 @@ private[spark] class TaskSchedulerImpl( // continue to run even after being asked to decommission, but they will eventually exit. val executorsPendingDecommission = new HashMap[String, ExecutorDecommissionState] + // Keep removed executors due to decommission, so getExecutorDecommissionState + // still return correct value even after executor is lost + val removedExecutorsDueToDecom = new mutable.LinkedHashMap[String, ExecutorDecommissionState] Review Comment: Also, rename variable to `executorsRemovedByDecom` or some such. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
