cloud-fan commented on code in PR #38356:
URL: https://github.com/apache/spark/pull/38356#discussion_r1021136795
##########
sql/core/src/test/scala/org/apache/spark/sql/sources/PartitionedWriteSuite.scala:
##########
@@ -220,6 +220,23 @@ class PartitionedWriteSuite extends QueryTest with
SharedSparkSession {
}
}
}
+
+ test("SPARK-40885: V1 write uses the sort with partitionBy operator") {
+ withTempPath { f =>
+ Seq((20, 30, "partition"), (15, 20, "partition"),
+ (30, 70, "partition"), (18, 40, "partition"))
+ .toDF("id", "sort_col", "p")
+ .repartition(1)
+ .sortWithinPartitions("p", "sort_col")
+ .write
+ .partitionBy("p")
Review Comment:
Seems `Project` shouldn't extend `OrderPreservingUnaryNode`, as it needs to
rewrite the child output ordering based on the project list. cc @ulysses-you
@wangyum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
