zhengruifeng commented on PR #38659: URL: https://github.com/apache/spark/pull/38659#issuecomment-1314662296
@dengziming thanks for the contributions! I think we'd better apply Arrow batch instead of structs in this proto message. you may refer to https://github.com/apache/spark/pull/38468 on how to update the proto message, and the implementation of [fromBatchIterator](https://github.com/apache/spark/blob/a45b0811ef22e2b66d52d066784e3fd2d9107f9d/sql/core/src/main/scala/org/apache/spark/sql/execution/arrow/ArrowConverters.scala#L216-L266) on how to convert arrow batches into internal rows; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
