grundprinzip commented on code in PR #38631:
URL: https://github.com/apache/spark/pull/38631#discussion_r1022503590
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -44,7 +44,7 @@
from pyspark.sql.connect.typing import ColumnOrString, ExpressionOrString
from pyspark.sql.connect.client import RemoteSparkSession
-ColumnOrName = Union[Column, str]
+ColumnOrName = Union[Expression, str]
Review Comment:
I think this fell out of a different PR I had for transform. The reason we
need it eventually is because right now from a type perspective select can only
use columns but should be able to refer to any expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
