cloud-fan commented on code in PR #38495:
URL: https://github.com/apache/spark/pull/38495#discussion_r1023592944
##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala:
##########
@@ -609,6 +609,20 @@ private[hive] class HiveClientImpl(
shim.alterTable(client, qualifiedTableName, hiveTable)
}
+ override def alterTableStats(
+ dbName: String,
+ tableName: String,
+ stats: Map[String, String]): Unit = withHiveState {
+ val hiveTable = getRawHiveTable(dbName,
tableName).rawTable.asInstanceOf[HiveTable]
+ val newParameters = new JHashMap[String, String]()
+
hiveTable.getParameters.asScala.toMap.filterNot(_._1.startsWith(STATISTICS_PREFIX))
Review Comment:
It's a bit tricky to make `HiveClient` handle this `STATISTICS_PREFIX`. It
should be the responsibility of `HiveExternalCatalog`. `HiveClient` should only
take care of the communication with HMS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
