yabola commented on code in PR #38560:
URL: https://github.com/apache/spark/pull/38560#discussion_r1023828427
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -654,8 +731,7 @@ public MergeStatuses
finalizeShuffleMerge(FinalizeShuffleMerge msg) {
// If no blocks pushed for the finalizeShuffleMerge shuffleMergeId
then return
// empty MergeStatuses but cleanup the older shuffleMergeId files.
submitCleanupTask(() ->
- closeAndDeleteOutdatedPartitions(
- appAttemptShuffleMergeId,
mergePartitionsInfo.shuffleMergePartitions));
+ deleteCurrentShufflePartitions(appShuffleInfo, shuffleId,
appAttemptShuffleMergeId));
Review Comment:
And I think when deleting partition information, we may don’t store
shuffleMergeID in DB anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
