gaoyajun02 commented on code in PR #38333:
URL: https://github.com/apache/spark/pull/38333#discussion_r1023946842
##########
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala:
##########
@@ -794,7 +794,18 @@ final class ShuffleBlockFetcherIterator(
// since the last call.
val msg = s"Received a zero-size buffer for block $blockId from
$address " +
s"(expectedApproxSize = $size,
isNetworkReqDone=$isNetworkReqDone)"
- throwFetchFailedException(blockId, mapIndex, address, new
IOException(msg))
+ if (blockId.isShuffleChunk) {
+ // Zero-size block may come from nodes with hardware failures,
For shuffle chunks,
+ // the original shuffle blocks that belong to that zero-size
shuffle chunk is
+ // available and we can opt to fallback immediately.
+ logWarning(msg)
+
pushBasedFetchHelper.initiateFallbackFetchForPushMergedBlock(blockId, address)
+ // Set result to null to trigger another iteration of the while
loop to get either.
+ result = null
+ null
+ } else {
+ throwFetchFailedException(blockId, mapIndex, address, new
IOException(msg))
+ }
}
val in = try {
Review Comment:
resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
