srowen commented on code in PR #38610: URL: https://github.com/apache/spark/pull/38610#discussion_r1024140597
########## sql/catalyst/src/main/scala-2.12/org/apache/spark/sql/catalyst/expressions/AttributeMap.scala: ########## @@ -31,6 +31,10 @@ object AttributeMap { new AttributeMap(kvs.map(kv => (kv._1.exprId, kv)).toMap) } + def apply[A](kvs: Iterable[(Attribute, A)]): AttributeMap[A] = { + new AttributeMap(kvs.map(kv => (kv._1.exprId, kv)).toMap) + } + Review Comment: I don't think it matters either way; we can keep it or not -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org