dongjoon-hyun commented on code in PR #38441:
URL: https://github.com/apache/spark/pull/38441#discussion_r1024244358
##########
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala:
##########
@@ -2004,17 +2006,30 @@ class TaskSchedulerImplSuite extends SparkFunSuite with
LocalSparkContext
// executor1 is eventually lost
scheduler.executorLost("executor1", ExecutorExited(0, false, "normal"))
- assert(scheduler.executorsPendingDecommission.isEmpty)
+ // [SPARK-40481] after executor lost, decommission state still be kept
Review Comment:
Please remove `[SPARK-40481]`
##########
core/src/test/scala/org/apache/spark/scheduler/TaskSchedulerImplSuite.scala:
##########
@@ -2004,17 +2006,30 @@ class TaskSchedulerImplSuite extends SparkFunSuite with
LocalSparkContext
// executor1 is eventually lost
scheduler.executorLost("executor1", ExecutorExited(0, false, "normal"))
- assert(scheduler.executorsPendingDecommission.isEmpty)
+ // [SPARK-40481] after executor lost, decommission state still be kept
+ assert(scheduler.getExecutorDecommissionState("executor1").isDefined)
// So now both the tasks are no longer running
- assert(manager.copiesRunning.take(2) === Array(0, 0))
+
+ // executor 2 is decommissioned, then lost
+ scheduler.executorDecommission("executor2", ExecutorDecommissionInfo("",
None))
+ scheduler.executorLost("executor2", ExecutorExited(0, false, "normal"))
+
+ // [SPARK-40481] only keep 1 removed executor info
Review Comment:
Please remove `[SPARK-40481]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
