Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/6039#issuecomment-103177221
@hhbyyh Thanks for the update! Do you think we really need a copy of the
scaler in the spark.mllib package? The problem with adding it is that it's
duplicating the functionality of the spark.ml version, and we'll have to
maintain that code forever. Unless there's a clear need, could you please
remove the spark.mllib version?
Can you also please add unit tests?
For parameter names, do "upperBound" and "lowerBound" seem longer than
needed? What about either (a) "lower" and "upper" or (b) "min" and "max"? I'd
vote for (b) unless we're afraid of name conflicts since min/max match the name
of the class.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
