itholic commented on code in PR #38644:
URL: https://github.com/apache/spark/pull/38644#discussion_r1025941541
##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastWithAnsiOnSuite.scala:
##########
@@ -244,7 +244,7 @@ class CastWithAnsiOnSuite extends CastSuiteBase with
QueryErrorsBase {
Decimal("12345678901234567890123456789012345678"))
checkExceptionInExpression[ArithmeticException](
cast("123456789012345678901234567890123456789", DecimalType(38, 0)),
- "Out of decimal type range")
+ "NUMERIC_OUT_OF_SUPPORTED_RANGE")
Review Comment:
Let me just test with `checkExceptionInExpression` for now, since it failed
in CI when use `checkError` because `checkError` doesn't support for various
test Mode such as "non-codegen mode", "codegen mode" and "unsafe mode" for now.
I think we might need to similar test utils for expression test such as
`checkErrorInExpression` something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
