LuciferYang commented on code in PR #38064:
URL: https://github.com/apache/spark/pull/38064#discussion_r1025955547
##########
sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala:
##########
@@ -2228,6 +2231,31 @@ class DatasetSuite extends QueryTest
}
}
+class DatasetLargeResultCollectingSuite extends QueryTest
+ with SharedSparkSession {
+
+ override protected def sparkConf: SparkConf =
super.sparkConf.set(MAX_RESULT_SIZE.key, "4g")
+ test("collect data with single partition larger than 2GB bytes array limit")
{
+ // This test requires large memory and leads to OOM in Github Action so we
skip it. Developer
+ // should verify it in local build.
+ assume(!sys.env.contains("GITHUB_ACTIONS"))
Review Comment:
@HyukjinKwon @mridulm @jiangxb1987 @sadikovi @Ngone51 I failed to run this
case locally with Spark default Java options. Could you run successfully? Or
should we ignore this case by default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
