HeartSaVioR commented on code in PR #38719:
URL: https://github.com/apache/spark/pull/38719#discussion_r1026994040
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/ProgressReporter.scala:
##########
@@ -345,7 +345,14 @@ trait ProgressReporter extends Logging {
val allExecPlanLeaves = lastExecution.executedPlan.collectLeaves()
if (allLogicalPlanLeaves.size == allExecPlanLeaves.size) {
val execLeafToSource =
allLogicalPlanLeaves.zip(allExecPlanLeaves).flatMap {
- case (lp, ep) => logicalPlanLeafToSource.get(lp).map { source => ep
-> source }
+ case (_, ep: MicroBatchScanExec) =>
+ // SPARK-41199: `logicalPlanLeafToSource` contains OffsetHolder
instance for DSv2
+ // streaming source, hence we cannot lookup the actual source from
the map.
+ // The physical node for DSv2 streaming source contains the
information of the source
+ // by itself, so leverage it.
+ Some(ep -> ep.stream)
Review Comment:
So all the problems from streaming query metrics are due to DSv1 which we do
not have a dedicated logical node / physical node for source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
