MaxGekk commented on PR #38685: URL: https://github.com/apache/spark/pull/38685#issuecomment-1322204472
> The main question is whether we should have a distinct error messages for duplicate identifier in "constructors". Don't think this is a significant issue. A column might already exist in a constructor, partition spec itself. > Should this say: MAP_KEY_ALREADY_EXISTS Yep, we can say that key already exist in the provided map. If we introduce one more error class like `DUPLICATED_COLUMN`, this could bring just additional questions what is the difference. I would just follow the existing convention, and name the error class as `*_ALREADY_EXISTS`, and do refactoring later if it is needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
