cloud-fan commented on code in PR #38302: URL: https://github.com/apache/spark/pull/38302#discussion_r1028926326
########## sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala: ########## @@ -56,7 +56,10 @@ case class SparkListenerSQLExecutionStart( } @DeveloperApi -case class SparkListenerSQLExecutionEnd(executionId: Long, time: Long) +case class SparkListenerSQLExecutionEnd( + executionId: Long, + time: Long, + errorMessage: Option[String] = None) Review Comment: This is not a public class. It generates JSON string where backward compatibility matters, and this PR added tests for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
