grundprinzip commented on code in PR #38742:
URL: https://github.com/apache/spark/pull/38742#discussion_r1029500646
##########
connector/connect/src/main/protobuf/spark/connect/base.proto:
##########
@@ -100,18 +70,138 @@ message AnalyzePlanRequest {
// logging purposes and will not be interpreted by the server.
optional string client_type = 4;
- // (Optional) Get the explain string of the plan.
- Explain explain = 5;
+ repeated AnalysisTask tasks = 5;
+
+ message AnalysisTask {
+ oneof task {
+ // Get the schema
+ Schema schema = 1;
+
+ // Is local
+ IsLocal is_local = 2;
+
+ // Is Streaming
+ IsStreaming is_streaming = 3;
+
+ // Get the explain string of the plan.
+ Explain explain = 4;
Review Comment:
again, why an extra message type just to encapsulate an enum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
