ahshahid commented on code in PR #38714:
URL: https://github.com/apache/spark/pull/38714#discussion_r1029822940
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/subquery.scala:
##########
@@ -208,20 +208,33 @@ object SubExprUtils extends PredicateHelper {
*/
def getOuterReferences(expr: Expression): Seq[Expression] = {
val outerExpressions = ArrayBuffer.empty[Expression]
- def collectOutRefs(input: Expression): Unit = input match {
+
+ def collectOutRefs(input: Expression): Boolean = input match {
case a: AggregateExpression if containsOuter(a) =>
if (a.references.nonEmpty) {
throw QueryCompilationErrors.mixedRefsInAggFunc(a.sql, a.origin)
} else {
// Collect and update the sub-tree so that outer references inside
this aggregate
// expression will not be collected. For example: min(outer(a)) ->
min(a).
- val newExpr = stripOuterReference(a)
- outerExpressions += newExpr
+ // delay collecting outer expression as we want to go as much up as
possible
Review Comment:
But you are right.. I suppose so long as any expression is such that so
long as only one of the child returns "true", then the current expression can
be part of the outer ref.
so basically it means that as long as the situation is not like. (sum(a) +
sum(b) + 8, types... the expression can be considered to be referencable
using outer ref.
Will make that change..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
